sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry
fails with NPE with LedgerHandlerAdv
URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127567837
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -165,6 +165,11 @@ public void asyncAddEntry(final long entryId, final
byte[] data, final int offse
*/
@Override
protected void doAsyncAddEntry(final PendingAddOp op, final ByteBuf data,
final AddCallback cb, final Object ctx) {
+ if (op.entryId < 0 ) {
Review comment:
when will this happen? I think this change volatiles the semantic of
LedgerHandleAdv#asyncAddEntry. if the entry id is negative, we should reject
this add with illegal arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
