sijie commented on a change in pull request #266: Issue 265: Add persistable 
bookie status
URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891121
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -857,7 +884,13 @@ public synchronized void start() {
 
         ledgerStorage.start();
 
-        syncThread.start();
+        // check the bookie status to start with
+        if (forceReadOnly.get()) {
 
 Review comment:
   yes, forceReadOnly will override status from disk. The forceReadOnly is set 
when setForceReadOnly is configured. That is documented in service 
configuration.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to