merlimat commented on a change in pull request #298: Issue 295: LocalBookKeeper
fails to start up
URL: https://github.com/apache/bookkeeper/pull/298#discussion_r129632908
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
##########
@@ -299,6 +297,9 @@ static void startLocalBookiesInternal(ServerConfiguration
conf,
}
throw ie;
}
+ } catch (Exception e) {
Review comment:
If we catch the exception here, it means we are not exiting the process. I
would say to not catch here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
