kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129645246
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ########## @@ -303,12 +304,15 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) synchronized (this) { if (authenticated) { super.write(ctx, msg, promise); + super.flush(ctx); } else if (msg instanceof BookkeeperProtocol.Request) { // let auth messages through, queue the rest BookkeeperProtocol.Request req = (BookkeeperProtocol.Request) msg; if (req.getHeader().getOperation() - == BookkeeperProtocol.OperationType.AUTH) { + == BookkeeperProtocol.OperationType.AUTH + || req.getHeader().getOperation() == BookkeeperProtocol.OperationType.START_TLS) { super.write(ctx, msg, promise); + super.flush(ctx); Review comment: No writeAndFlush() api in channelDuplexHandler ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services