eolivelli commented on a change in pull request #301: Issue-299
EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743899
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/GenericEnsemblePlacementPolicyTest.java
##########
@@ -132,9 +132,9 @@ public void testReplaceBookie() throws Exception {
lh.addEntry(value);
}
}
- assertEquals(2, customMetadataOnNewEnsembleStack.size());
Review comment:
yes this is a "change", but it is not possible to do in another way, because
we need to call the 'legacy' method by default and the class in the the does
not override it.
I have preferred to change the assertion instead of changing the test
policy, the fact that the legacy method is called is covered by the new test
class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
