eolivelli commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r130331025
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ########## @@ -2023,7 +2027,49 @@ public ServerConfiguration setNettyMaxFrameSizeBytes(int maxSize) { } /** - * Gets the minimum safe Usable size to be available in index directory for Bookie to create Index File while replaying + * Sets that whether the http server can start along with auto-recovery service + * + * @param enabled + * - true if need to start http server with auto-recovery + * @return ServerConfiguration + */ + public ServerConfiguration setHttpServerEnabled(boolean enabled) { + setProperty(HTTP_SERVER_ENABLED, enabled); + return this; + } + + /** + * Get whether the http server start with auto-recovery service or not Review comment: comment is not correct at 100%, this options applied both to the bookie and to the auto-recovery daemon ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services