I think both approaches are viable, but I think that the max allowable version is more naturally a bk cluster property rather than a bk client property. Controlling this from the client means that the same client version deployed to two different clusters might need different settings depending on the other clients deployed to those clusters. Placing it in the metadata means that the clients simply pick up the correct version for the environment from the ledger metadata without needing additional configuration. However, client config management is likely to be managed on a per-cluster basis anyway, so in practice there may be little difference. -Sam
On Tue, Dec 18, 2018 at 10:01 AM Sam Just <sj...@salesforce.com> wrote: > I'll take a look. > > On Tue, Dec 18, 2018 at 1:39 AM Ivan Kelly <iv...@apache.org> wrote: > >> JV, Sam, Charan, Andrey, could one of you chime in on this? It's >> holding up 4.9 release. >> >> -Ivan >> >> On Thu, Dec 13, 2018 at 5:38 PM Ivan Kelly <iv...@apache.org> wrote: >> > >> > I'd be interested to see the opinion of the salesforce folks on this. >> > On Thu, Dec 13, 2018 at 5:35 PM Ivan Kelly <iv...@apache.org> wrote: >> > > >> > > > I am not sure about this. If clients don't react the changes of >> ledger >> > > > layout, >> > > > the information in ledger layout is just informative, you still >> need to >> > > > coordinate >> > > > both readers and writers. so IMO the version in ledger layout is >> not really >> > > > useful. >> > > >> > > The clients react the next time they initialize the ledger manager. >> > > Which is exactly the same as would occur with a configuration setting. >> > > >> > > -Ivan >> > > > -- > > <http://smart.salesforce.com/sig/sjust//us_mb/default/link.html> > -- <http://smart.salesforce.com/sig/sjust//us_mb/default/link.html>
