On Tue, Jan 22, 2019 at 8:40 AM Enrico Olivelli <eolive...@gmail.com> wrote:
> Hi all, > while reviewing 4.9 release I found this problem around a change about > EnsemblePlacementPolicy > > this is the issue > https://github.com/apache/bookkeeper/issues/1914 > > The problem is that in public API we should not use third party > classes in order to preserve compatibility with incompatible changes > of the third party library. > > We already had such problems in the past. > > I think the best way to address this problem is to introduce one > specific class in BookKeeper, maybe an inner class of > EnsemblePlacementPolicy. > why not just introduce a Pair like class in bookkeeper-common module? instead of an inner class for EnsemblePlacementPolicy. > > If we agree on this solution I can send the patch, it is very > straightforward > > Regards > Enrico >