+1 (binding from me too) - Licenses are good - rat, unit tests pass (some issues with checkstyle, but not going to let that block anything) - sig & sha512 good
-Ivan On Wed, Mar 13, 2019 at 11:05 AM Enrico Olivelli <eolive...@gmail.com> wrote: > > +1 (binding) > run tests on Fedora + java 8 (some known flaky test faiiled, not > blocker for this release) > checked signatures and checksums > run smoke tests with java 8 and localbookie and the bookkeeper shell > > Thank you Ivan > #shipit > > Enrico > > Il giorno lun 11 mar 2019 alle ore 09:05 Sijie Guo > <guosi...@gmail.com> ha scritto: > > > > +1 (binding) > > > > - verified source & binary package > > - asc & sha512 are good > > - artifacts are good > > - tag is good > > > > On Sat, Mar 9, 2019 at 2:28 AM Ivan Kelly <iv...@apache.org> wrote: > > > > > Hi everyone, > > > Please review and vote on the release candidate #0 for the version > > > 4.8.2, as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed > > > to dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.8.2-rc0" [4] with git sha > > > f6adb282f88ab56afa3ef33b15d7acaf4b307eef > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. Since it's late on > > > friday, I won't tally the votes until this 17:00 UTC on wednesday > > > 13th. > > > > > > Have a great weekend folks, > > > > > > Ivan > > > > > > [1] https://github.com/apache/bookkeeper/pull/1976 > > > [2] > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.8.2-rc0/ > > > [3] > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1039/ > > > [4] https://github.com/apache/bookkeeper/tree/v4.8.2-rc0 > > >
