Il Gio 21 Mag 2020, 12:34 Lamber-Ken <[email protected]> ha scritto:
> Dear community,
>
> I noticed that there is a lot of work to improve code quality.
>
It would be very welcome!
Thanks
> e.g
> 1. Not enough arguments.
> LOG.warn("Exception when reading header of {} : {}", lf, buf);
> 2. Optional.
> java.util.Optional and com.google.common.base.Optional can be merged.
>
+1 for java util.
3. @Slf4j
> @Slf4j / LoggerFactory.getLogger(xxx.class);
> ..
>
> We can use some tools to check them, then fix them manually or
> automatically, any thoughts?
>
It is better to split the work in several patches.
This way we can make review simpler
Enrico
>
> Thanks,
> Lamber-Ken
>