Lari and I have looked at the Netty upgrade. There are some test breaks, and so far everything is related to behavior changes related to TLS 1.3, see https://stackoverflow.com/a/62465859 We managed to fix some of the issues https://github.com/apache/bookkeeper/pull/2696 but "the client won't know whether the server has accepted the certificate or not until it next reads data from the server" complicates things.
Currently we are considering simply setting "java -Djdk.tls.client.protocols=TLSv1.2" to unbreak the tests and handling tls1.3 as a separate work item. Lari is planning on spending a little bit more time on this tomorrow (his tomorrow) to see if there is a better way to address this quickly; we'll hear more then. On Wed, May 5, 2021 at 9:23 AM Henry Saputra <henry.sapu...@gmail.com> wrote: > I am +1 for having next release as 4.14.0 > > - Henry > > On Tue, May 4, 2021 at 2:51 PM Andrey Yegorov <andrey.yego...@datastax.com > > > wrote: > > > Overall +1 for 4.14.0 - the milestone is due May 16th anyway. > > There is nothing that breaks compatibility with 4.13 so we can skip > 4.13.1. > > > > One thing I'd love to see in 4.14 is > > https://github.com/apache/bookkeeper/pull/2696 , to fix > > https://github.com/netty/netty/issues/10986 > > It looks like there are issues with vertx > > https://github.com/apache/bookkeeper/pull/2693#issuecomment-823774769 > > I hope we can upgrade to latest vertx 3.9.7 and netty 4.1.60 > > > > Also https://github.com/apache/bookkeeper/pull/2695 upgrades libthrift > to > > address security issues. > > > > All these PRs are from Lari, I'll follow up with him. > > > > I can be a RM if there are no other volunteers. > > > > > > On Tue, May 4, 2021 at 1:57 PM Matteo Merli <mme...@apache.org> wrote: > > > > > +1 We should do 4.14, carrying all the fixes that are there in master > as > > > well. > > > > > > > > > -- > > > Matteo Merli > > > <mme...@apache.org> > > > > > > On Tue, May 4, 2021 at 11:57 AM Sijie Guo <guosi...@gmail.com> wrote: > > > > > > > > +1 > > > > > > > > On Tue, May 4, 2021 at 2:22 AM Yunze Xu <y...@streamnative.io.invalid > > > > > > wrote: > > > > > > > > > Hello, > > > > > About 10 days ago I found a heap memory copy problem in Apache > > Pulsar, > > > see > > > > > [1]. > > > > > It’s a problem of BK side because when `LedgerHandle#asyncAddEntry` > > > > > accepts a `CompositeByteBuf` or a wrapper, it will finally call > > > > > `ByteBuf#nioBuffer()`, which would make a heap copy from direct > > memory. > > > > > [2] fixed this problem and has been merged for a week. > > > > > > > > > > Since it has a significant impact on Pulsar, Pulsar side needs a > new > > BK > > > > > release with [2] merged to fix it. Is there any plan to cut a > 4.13.1 > > > > > release or 4.14.0 release so that we can upgrade the dependency in > > > Pulsar? > > > > > > > > > > Thanks, > > > > > Yunze > > > > > > > > > > [1] https://github.com/apache/pulsar/pull/10330 < > > > > > https://github.com/apache/pulsar/pull/10330> > > > > > > > > > > [2] https://github.com/apache/bookkeeper/pull/2701 < > > > > > https://github.com/apache/bookkeeper/pull/2701> > > > > > > > > > > > > > > > > > > > -- > > > > -- > > Andrey Yegorov > > > -- -- Andrey Yegorov
