Il Mer 27 Apr 2022, 18:39 Andrey Yegorov <andrey.yego...@datastax.com> ha scritto:
> Hi, > > I can repro this on branch-4.15 (branch-4.14 is ok). > > The problem is these tests don't run on "mvn test" and I suspect they don't > run on CI too. > > To repro locally: > cd tests/scripts > > mvn clean install -DskipTests > mvn test > > -> success > > mvn clean install > > -> failed tests > Exactly the same failure I think we have to fix this. -1 Enrico > > #------------------------------------------------------------------------------ > # System data > # > # test run info > shells="/bin/sh /bin/bash" > tests="bk_test_bin_common.sh" > > # system info > $ date > Wed Apr 27 09:35:25 PDT 2022 > $ uname -mprsv > Darwin 20.6.0 Darwin Kernel Version 20.6.0: Wed Nov 10 22:23:07 PST 2021; > root:xnu-7195.141.14~1/RELEASE_X86_64 x86_64 i386 > > > #------------------------------------------------------------------------------ > # Running the test suite with /bin/sh > # > shell name: sh > shell version: 3.2.57(1)-release > > --- Executing the 'bin_common' test suite --- > testDefaultVariables > ASSERT:NETTY_RECYCLER_MAXCAPACITY is not set correctly expected:<1000> but > was:<> > ASSERT:NETTY_RECYCLER_LINKCAPACITY is not set correctly expected:<1024> but > was:<> > testFindModuleJarAt > testFindModuleJar > testLoadEnvfiles > testSetModuleClasspath > testBuildBookieJVMOpts > testBuildCLIJVMOpts > testBuildNettyOpts > testBuildBookieOpts > testBuildLoggingOpts > ASSERT:Logging OPTS is not set correctly > expected:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.log.root.level= > -Dbookkeeper.log.root.appender=test_log_dir > -Dbookkeeper.log.dir=test_log_dir -Dbookkeeper.log.file=test_log_file> > but was:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.log.root.level=INFO -Dbookkeeper.log.root.appender=TEST > -Dbookkeeper.log.dir=test_log_dir > -Dbookkeeper.log.file=test_log_file> > testBuildCLILoggingOpts > ASSERT:Logging OPTS is not set correctly > expected:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.cli.root.logger=INFO,TEST > -Dbookkeeper.cli.log.dir=test_log_dir > -Dbookkeeper.cli.log.file=test_log_file> but > was:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.cli.log.root.level=test_log_dir > -Dbookkeeper.cli.log.root.appender=test_log_file > -Dbookkeeper.cli.log.dir=INFO,TEST -Dbookkeeper.cli.log.file=> > > Ran 11 tests. > > FAILED (failures=4) > > > #------------------------------------------------------------------------------ > # Running the test suite with /bin/bash > # > shell name: bash > shell version: 3.2.57(1)-release > > --- Executing the 'bin_common' test suite --- > testDefaultVariables > ASSERT:NETTY_RECYCLER_MAXCAPACITY is not set correctly expected:<1000> but > was:<> > ASSERT:NETTY_RECYCLER_LINKCAPACITY is not set correctly expected:<1024> but > was:<> > testFindModuleJarAt > testFindModuleJar > testLoadEnvfiles > testSetModuleClasspath > testBuildBookieJVMOpts > testBuildCLIJVMOpts > testBuildNettyOpts > testBuildBookieOpts > testBuildLoggingOpts > ASSERT:Logging OPTS is not set correctly > expected:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.log.root.level= > -Dbookkeeper.log.root.appender=test_log_dir > -Dbookkeeper.log.dir=test_log_dir -Dbookkeeper.log.file=test_log_file> > but was:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.log.root.level=INFO -Dbookkeeper.log.root.appender=TEST > -Dbookkeeper.log.dir=test_log_dir > -Dbookkeeper.log.file=test_log_file> > testBuildCLILoggingOpts > ASSERT:Logging OPTS is not set correctly > expected:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.cli.root.logger=INFO,TEST > -Dbookkeeper.cli.log.dir=test_log_dir > -Dbookkeeper.cli.log.file=test_log_file> but > was:<-Dlog4j.configurationFile=test.conf > -Dbookkeeper.cli.log.root.level=test_log_dir > -Dbookkeeper.cli.log.root.appender=test_log_file > -Dbookkeeper.cli.log.dir=INFO,TEST -Dbookkeeper.cli.log.file=> > > Ran 11 tests. > > FAILED (failures=4) > > On Wed, Apr 27, 2022 at 9:04 AM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > Andrey, > > thanks for driving the release. > > > > I see this error while running the tests on the sources unpacked from > > the tarball > > > > it is the "scripts" project, that runs the tests against bash scripts: > > > > testBuildLoggingOpts > > > > ASSERT:Logging OPTS is not set correctly > > expected:<-Dlog4j.configurationFile=test.conf > > -Dbookkeeper.log.root.level= > > -Dbookkeeper.log.root.appender=test_log_dir > > -Dbookkeeper.log.dir=test_log_dir > > -Dbookkeeper.log.file=test_log_file> but > > was:<-Dlog4j.configurationFile=test.conf > > -Dbookkeeper.log.root.level=INFO > > -Dbookkeeper.log.root.appender=TEST > > -Dbookkeeper.log.dir=test_log_dir > > -Dbookkeeper.log.file=test_log_file> > > > > testBuildCLILoggingOpts > > > > ASSERT:Logging OPTS is not set correctly > > expected:<-Dlog4j.configurationFile=test.conf > > -Dbookkeeper.cli.root.logger=INFO,TEST > > -Dbookkeeper.cli.log.dir=test_log_dir > > -Dbookkeeper.cli.log.file=test_log_file> but > > was:<-Dlog4j.configurationFile=test.conf > > -Dbookkeeper.cli.log.root.level=test_log_dir > > -Dbookkeeper.cli.log.root.appender=test_log_file > > -Dbookkeeper.cli.log.dir=INFO,TEST -Dbookkeeper.cli.log.file=> > > > > > > Ran 11 tests. > > > > Il giorno mer 27 apr 2022 alle ore 02:33 Andrey Yegorov > > <andrey.yego...@datastax.com> ha scritto: > > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for the version > > 4.15.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "release-4.15.0-rc1" [4] with git > > > sha451c54b72651d7cecb23c96b69a5de7f7dc55bb1 > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Release Manager > > > > > > [1] > > > > > > https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855 > > > - > > > I will update the release notes to include changes between rc0 and rc1 > > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.0-rc1/ > > > > > > [3] > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1065/ > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.0-rc1/ > > > > > > -- > > > Andrey Yegorov > > > > > -- > Andrey Yegorov >
