-1 (non-binding) - Build from source code (jdk8 on MacOs) - Verified checksums and signatures - Checked the licenses - Run journal perf produce - Integrate with Pulsar master code and Pulsar unit tests passed
>From the license checking, I found the following license mismatch. ``` ch.qos.logback-logback-classic-1.2.10.jar unaccounted for in LICENSE ch.qos.logback-logback-core-1.2.10.jar unaccounted for in LICENSE io.netty-netty-tcnative-2.0.48.Final.jar unaccounted for in LICENSE io.netty-netty-transport-native-epoll-4.1.75.Final.jar unaccounted for in LICENSE It looks like there are issues with the LICENSE/NOTICE in ../bookkeeper-server-4.15.3-bin.tar.gz. ``` Thanks for Yong driving the release. Thanks, Hang Enrico Olivelli <eolive...@gmail.com> 于2022年11月8日周二 17:34写道： > > +1 (binding) > > - Built from sources (JDK11, MacOs) > - Run some smoke tests with localbookie > - Built and run smoke tests with Pulsar 2.11-SNAPSHOT > - Signatures/checksums look good > > Thanks for driving the release > > Enrico > > Il giorno ven 4 nov 2022 alle ore 03:43 Yong Zhang > <zhangyong1025...@gmail.com> ha scritto: > > > > Hi everyone, > > Please review and vote on the release candidate #0 for the version 4.15.3, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.15.3-rc0" [4] with git sha [5] > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] > > https://github.com/apache/bookkeeper/pull/3602/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53R4 > > <https://github.com/apache/bookkeeper/pull/3602/files> > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.3-rc0/ > > [3] > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1074 > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.3-rc0 > > [5] 029622128e82c5120d3c70f9fc0761e3687e05af
