Thank you for driving the release! On Sun, Nov 13, 2022 at 6:29 PM Yong Zhang <zhangyong1025...@gmail.com> wrote:
> The vote is now closed and the release was approved with > 4 +1s(3 bindings and 1 non-binding); > > Binding votes: > * Enrico Olivelli > * Andrey Yegorov > * Jia Zhai > > Non-Binding votes: > * Hang Chen > > Thank you all guys for voting! > > > > On Sat, 12 Nov 2022 at 16:14, Jia Zhai <zhai...@apache.org> wrote: > > > +1 (binding) > > > > - verified packages checksum and signatures, they look good. > > > > - the source package build and test all run successfully. > > > > - 'bin/bookkeeper standalone' and 'bin/bookkeeper shell bookiesanity' run > > well. > > > > > > On Sat, Nov 12, 2022 at 8:54 AM Hang Chen <chenh...@apache.org> wrote: > > > > > +1 (non-binding) > > > > > > - Build from source code (JDK8, maven 3.8.6 on MacOs) > > > - Verified checksums and signatures > > > - Verified the licenses > > > - Run bkperf to test journal write > > > - Integrate with Pulsar master code and Pulsar unit tests passed > > > （https://github.com/hangc0276/pulsar/pull/7） > > > > > > > > > Thanks Yong for driving the release > > > > > > Thanks, > > > Hang > > > > > > Andrey Yegorov <andrey.yego...@datastax.com> 于2022年11月12日周六 00:08写道： > > > > > > > > +1 (binding) > > > > > > > > On Thu, Nov 10, 2022 at 8:06 PM Yong Zhang < > zhangyong1025...@gmail.com > > > > > > > wrote: > > > > > > > > > Hi Andrey, > > > > > > > > > > I run the test multiple times, I found that depends on how the DNS > > > > > resolve the address. > > > > > When the DNS resolves to 127.0.0.1/localhost, the test will be > > failed. > > > > > But if it resolves another INet interface, like lo0, the hostname > > will > > > be > > > > > 192.168.50.240(in my computer) and the test passed. > > > > > > > > > > Thanks, > > > > > Yong > > > > > > > > > > On Fri, 11 Nov 2022 at 09:46, Yong Zhang < > zhangyong1025...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > I downloaded the src package and run the tests successfully. > > > > > > And build from branch-4.15 passed as well. But failed when > > > > > > I run it with IDE. > > > > > > > > > > > > It looks like sometimes it uses the loopback address and we > > > > > > are not allowed that. > > > > > > But it shouldn't be a problem for this release. > > > > > > > > > > > > Thanks, > > > > > > Yong > > > > > > > > > > > > On Fri, 11 Nov 2022 at 09:01, Andrey Yegorov < > > > > > andrey.yego...@datastax.com> > > > > > > wrote: > > > > > > > > > > > >> I tested the following: > > > > > >> > > > > > >> * bookkeeper-all > > > > > >> ** unpacks > > > > > >> ** shell works, standalone starts, localbookie starts > > > > > >> * src > > > > > >> ** unpacks, builds > > > > > >> ** tests - there are some know flakes > > > > > >> and org.apache.bookkeeper.client.TestSpeculativeRead fails for > me > > > > > >> > > > > > >> I don't recall any issues with TestSpeculativeRead in the > previous > > > > > >> releases; does it repro for you (I built from unpacked sources > for > > > the > > > > > >> RC)? > > > > > >> > > > > > >> $ mvn test -f bookkeeper-server/pom.xml > > > > > >> -Dtest=org.apache.bookkeeper.client.TestSpeculativeRead > > > > > >> > > > > > >> [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time > > > elapsed: > > > > > >> 73.673 s <<< FAILURE! - in > > > > > >> org.apache.bookkeeper.client.TestSpeculativeRead > > > > > >> [ERROR] > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble > > > > > >> Time elapsed: 6.341 s <<< ERROR! > > > > > >> java.lang.RuntimeException: > > > > > >> java.net.UnknownHostException: Trying to listen on loopback > > address, > > > > > >> 127.0.0.1:3181 but this is forbidden by default (see > > > > > >> ServerConfiguration#getAllowLoopback()). > > > > > >> If this happen, you can consider specifying the network > interface > > to > > > > > >> listen > > > > > >> on (e.g. listeningInterface=eth0) or specifying the advertised > > > address > > > > > >> (e.g. advertisedAddress=172.x.y.z) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:68) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.client.BookKeeper.initializeEnsemblePlacementPolicy(BookKeeper.java:583) > > > > > >> at > > > org.apache.bookkeeper.client.BookKeeper.<init>(BookKeeper.java:507) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.client.BookKeeperTestClient.<init>(BookKeeperTestClient.java:51) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.client.TestSpeculativeRead.testSequenceReadLocalEnsemble(TestSpeculativeRead.java:395) > > > > > >> at > > > > > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > > > > > >> Method) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > > > > >> at java.base/java.lang.reflect.Method.invoke(Method.java:566) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > > > > > >> at > > > java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > > > > > >> at java.base/java.lang.Thread.run(Thread.java:829) > > > > > >> Caused by: java.net.UnknownHostException: Trying to listen on > > > loopback > > > > > >> address, 127.0.0.1:3181 but this is forbidden by default (see > > > > > >> ServerConfiguration#getAllowLoopback()). > > > > > >> If this happen, you can consider specifying the network > interface > > to > > > > > >> listen > > > > > >> on (e.g. listeningInterface=eth0) or specifying the advertised > > > address > > > > > >> (e.g. advertisedAddress=172.x.y.z) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.bookie.BookieImpl.getBookieAddress(BookieImpl.java:292) > > > > > >> at > > > > > >> > > > > org.apache.bookkeeper.bookie.BookieImpl.getBookieId(BookieImpl.java:247) > > > > > >> at > > > > > >> > > > > > >> > > > > > > > > > > > org.apache.bookkeeper.bookie.LocalBookieEnsemblePlacementPolicy.initialize(LocalBookieEnsemblePlacementPolicy.java:65) > > > > > >> ... 18 more > > > > > >> > > > > > >> On Wed, Nov 9, 2022 at 1:06 AM Yong Zhang < > > > zhangyong1025...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > >> > Hi everyone, > > > > > >> > Please review and vote on the release candidate #0 for the > > version > > > > > >> 4.15.3, > > > > > >> > as follows: > > > > > >> > [ ] +1, Approve the release > > > > > >> > [ ] -1, Do not approve the release (please provide specific > > > comments) > > > > > >> > > > > > > >> > The complete staging area is available for your review, which > > > > > includes: > > > > > >> > * Release notes [1] > > > > > >> > * The official Apache source and binary distributions to be > > > deployed > > > > > to > > > > > >> > dist.apache.org [2] > > > > > >> > * All artifacts to be deployed to the Maven Central Repository > > [3] > > > > > >> > * Source code tag "v4.15.3-rc0" [4] with git sha [5] > > > > > >> > > > > > > >> > BookKeeper's KEYS file contains PGP keys we used to sign this > > > release: > > > > > >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > >> > > > > > > >> > Please download these packages and review this release > > candidate: > > > > > >> > > > > > > >> > - Review release notes > > > > > >> > - Download the source package (verify shasum, and asc) and > > follow > > > the > > > > > >> > instructions to build and run the bookkeeper service. > > > > > >> > - Download the binary package (verify shasum, and asc) and > > follow > > > the > > > > > >> > instructions to run the bookkeeper service. > > > > > >> > - Review maven repo, release tag, licenses, and any other > things > > > you > > > > > >> think > > > > > >> > it is important to a release. > > > > > >> > > > > > > >> > The vote will be open for at least 72 hours. It is adopted by > > > majority > > > > > >> > approval, with at least 3 PMC affirmative votes. > > > > > >> > > > > > > >> > Thanks, > > > > > >> > Release Manager > > > > > >> > > > > > > >> > [1] > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > > > > https://github.com/apache/bookkeeper/pull/3602/files#diff-d361215d5d5abaa96ac3362e70a1d2f80f92d369a59c866e1976ff41ec435f53R4 > > > > > >> > <https://github.com/apache/bookkeeper/pull/3602/files> > > > > > >> > [2] > > > > > >> > > > > > > >> > > > > > > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.3-rc1/ > > > > > >> > [3] > > > > > >> > > > > > > >> > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1074 > > > > > >> > [4] > > https://github.com/apache/bookkeeper/releases/tag/v4.15.3-rc1 > > > > > >> > [5] 50f6820f31528fbd08aeecae89e6106ff67e7c8f > > > > > >> > > > > > > >> > > > > > >> > > > > > >> -- > > > > > >> Andrey Yegorov > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Andrey Yegorov > > > > > > -- Andrey Yegorov
