+1 (non-binding) sorry,I seem to have misunderstood, I thought you reverted first, and then proposed a replacement, these PRs( #3796 <https://github.com/apache/bookkeeper/pull/3796> #3398 <https://github.com/apache/bookkeeper/pull/3398> ) is for different branches.
steven lu <lushiji2...@gmail.com> 于2023年3月6日周一 11:36写道： > -1 (non-binding) > for new BP-61 : > 1) I think no need to revert 12 PRs to refactor the ByteBuf release method > 2) Directly replace ReferenceCountUtil.safeRelease() with > ReferenceCountUtil.release() > > > Hang Chen <chenh...@apache.org> 于2023年2月21日周二 12:38写道： > >> Hi, All >> >> After a fascinating discussion, I would start the vote for BP-61. >> >> We will replace the `ReferenceCountUtil.safeRelease()` with >> `ReferenceCountUtil.release()`. >> >> Please leave +1/-1 in this thread to join the vote. And feel free to >> leave any concerns. >> >> Thanks to you guys. >> >> Best, >> Hang >> >> References: >> - BP: https://github.com/apache/bookkeeper/issues/3792 >> - Discussion >> https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc >> >
