The vote is now closed and the release was approved with 4 +1s(3 bindings and 1 non-binding);
Binding votes: * Enrico Olivelli * Andrey Yegorov * Jia Zhai Non-Binding votes: * Hang Chen Thanks to all guys for voting! On Mon, 13 Mar 2023 at 10:15, Yong Zhang <zhangyong1025...@gmail.com> wrote: > The failed tests introduced by a test improvement > <https://github.com/apache/bookkeeper/pull/3415/files>, I think it should > be ok to close this vote first. > > Yong > > On Thu, 9 Mar 2023 at 22:18, Enrico Olivelli <eolive...@gmail.com> wrote: > >> +1 (binding) >> >> - Checked signatures/checksums >> - Built locally from sources, run some tests >> >> Enrico >> >> >> There is one test that always fails on my machine: >> [ERROR] Failures: >> [ERROR] >> org.apache.bookkeeper.test.BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour >> [ERROR] Run 1: >> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie >> should shutdown on losing zk session >> [ERROR] Run 2: >> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie >> should shutdown on losing zk session >> [ERROR] Run 3: >> BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour:182 Bookie >> should shutdown on losing zk session >> [INFO] >> >> Il giorno gio 9 mar 2023 alle ore 01:30 Andrey Yegorov >> <andrey.yego...@datastax.com> ha scritto: >> > >> > +1 (binding) >> > >> > * reviewed release notes >> > * tested standalone & localbookie >> > * built from sources (Mac, OpenJDK 17) >> > * ran some tests for bookkeeper-server >> > >> > On Wed, Mar 1, 2023 at 11:30 PM Yong Zhang <zhangyong1025...@gmail.com> >> > wrote: >> > >> > > Hi everyone, >> > > Please review and vote on the release candidate #1 for version 4.15.4, >> > > as follows: >> > > [ ] +1, Approve the release >> > > [ ] -1, Do not approve the release (please provide specific comments) >> > > >> > > The complete staging area is available for your review, which >> includes: >> > > * Release notes [1] >> > > * The official Apache source and binary distributions to be deployed >> to >> > > dist.apache.org [2] >> > > * All artifacts to be deployed to the Maven Central Repository [3] >> > > * Source code tag "v4.15.4-rc0" [4] with git sha [5] >> > > >> > > BookKeeper's KEYS file contains the PGP keys we used to sign this >> release: >> > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS >> > > >> > > Please download these packages and review this release candidate: >> > > >> > > - Review release notes >> > > - Download the source package (verify shasum, and asc) and follow the >> > > instructions to build and run the bookkeeper service. >> > > - Download the binary package (verify shasum, and asc) and follow the >> > > instructions to run the bookkeeper service. >> > > - Review the maven repo, release tag, licenses, and any other things >> you >> > > think >> > > it is important to release. >> > > >> > > The vote will be open for at least 72 hours. It is adopted by majority >> > > approval, with at least 3 PMC affirmative votes. >> > > >> > > Thanks, >> > > Release Manager >> > > >> > > [1] https://github.com/apache/bookkeeper/pull/3831/files >> > > [2] >> > > >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.4-rc0/ >> > > [3] >> > > >> https://repository.apache.org/content/repositories/orgapachebookkeeper-1080 >> > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.4-rc0 >> > > [5] 44f87efb8121a9f5428e7ddc70656aee85f563bf >> > > >> > >> > >> > -- >> > Andrey Yegorov >> >
