+1 (non-binding) but workflow run failed, this pr cannot be merged, please see below for details https://github.com/apache/bookkeeper/pull/3981#issuecomment-1617613606
Andrey Yegorov <ayego...@apache.org> 于2023年6月7日周三 06:38写道： > Hi, > > We have a few problems related to integration tests: > > 1. backwards compat tests did not include recent releases. > https://github.com/apache/bookkeeper/pull/3981 is supposed to fix that > > 2. Integration/backwards compat tests do not run on CI > E.g.: > > > mvn -B -nsu -DintegrationTests -pl :upgrade test > .. > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 > > > and the same is with other tests in the integration test suites. CI does > not fail in this case. > > This means that we didn't have backwards compat tests executed during the > last releases. > > For the context, I started on this path as a follow up to a report of > problems during BK/pulsar upgrade > https://apache-pulsar.slack.com/archives/C5ZSVEN4E/p1686019408280939 > > Adding > ``` > <dependency> > <groupId>org.junit.vintage</groupId> > <artifactId>junit-vintage-engine</artifactId> > <version>${junit5.version}</version> > <scope>test</scope> > </dependency> > ``` > to the backwards compat modules makes mvn find the test but there are > missing dependencies and/or some conflicts in the runtime that I haven't > figured out. > > I'd appreciate help from someone who understands what the heck Arquillian > test runner (used in groovy tests) needs. > > -- > Andrey >
