>> Please ensure that on CI we always both the 2 families of tests until we completed the migration
It works well. Yes, Like in workflow https://github.com/apache/bookkeeper/actions/runs/8873903044/job/24360578932. TestDirectReader,TestDirectWriter runs normally, and they are already junit5. I created https://github.com/apache/bookkeeper/issues/4322 to track this migrate. Thanks ZhangJian He On Mon, Apr 29, 2024 at 2:39 PM Enrico Olivelli <eolive...@gmail.com> wrote: > ZhangJian > > Il giorno mer 24 apr 2024 alle ore 18:58 ZhangJian He <shoot...@gmail.com> > ha scritto: > > > I am reaching out to propose a gradual migration of our testing framework > > from JUnit 4 to JUnit 5 across the BookKeeper. JUnit 5 offers significant > > improvements over JUnit 4, including more powerful and flexible testing > > capabilities like annotation-based coding(so we don't need to write > > assume), parallel test execution, and other features. > > > > > +1 > > Please ensure that on CI we always both the 2 families of tests until we > completed the migration > > Thank you > Enrico > > > > > > > > I think we can write new test classes using junit5, and existing-test > > classes can be slowly migrated. > > > > Thanks > > ZhangJian He > > >
