Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1098#discussion_r47368496
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlNodeImpl.java
---
@@ -135,8 +135,8 @@ protected void disconnectSensors() {
public int getPort() {
return getAttribute(MYSQL_PORT);
}
-
- public String getSocketUid() {
+
+ public synchronized String getSocketUid() {
--- End diff --
Post merge comment... I'd have preferred if we'd declared a `private final
Object mutex` to synchronize on. This is probably ok, but in general I don't
like synchronizing on `this` in case other threads/callers have synchronized on
this in other situations. No strong feelings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
