Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1110#discussion_r47898623
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java ---
@@ -59,7 +60,20 @@
* Creates a new AttributeMap.
*
* @param entity the EntityLocal this AttributeMap belongs to.
- * @throws IllegalArgumentException if entity is null
+ * @throws NullPointerException if entity is null
+ */
+ public AttributeMap(AbstractEntity entity) {
+ // Not using ConcurrentMap, because want to (continue to) allow
null values.
+ // Could use ConcurrentMapAcceptingNullVals (with the associated
performance hit on entrySet() etc).
+ this(entity, Collections.synchronizedMap(Maps.<Collection<String>,
Object>newLinkedHashMap()));
+ }
+
+ /**
+ * Creates a new AttributeMap.
+ *
+ * @param entity the EntityLocal this AttributeMap belongs to.
+ * @param values the Map in which to store the values - should be
concurrent or synchronized.
--- End diff --
values should be storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
