Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1120#discussion_r48335258
  
    --- Diff: 
usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java
 ---
    @@ -124,6 +126,19 @@ public void testDslAttributeWhenReady() throws 
Exception {
         }
     
         @Test
    +    public void testDslAttributeWhenReadyPersisted() throws Exception {
    --- End diff --
    
    For the `java.io.NotSerializableException`: that's surprising. We shouldn't 
be relying on normal java serialization. We use xstream for persistence, which 
doesn't need `Serializable`.
    
    Some test assertions can enable a stronger assertion about being able to 
serialize all of the persisted state using java serialization (in an attempt to 
fail-fast). We can just disable that, if it's being done. It's too strict.
    
    Worth looking down the stacktrace to see what is trying to do the java 
serialization, to see if it is the test assertion or something else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to