Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48562878
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
 ---
    @@ -1608,7 +1606,35 @@ protected SshMachineLocation 
createTemporarySshMachineLocation(HostAndPort hostA
             }
         }
     
    -    
    +    /**
    +     * Creates a temporary WinRM machine location (i.e. will not be 
persisted), which uses the given credentials.
    --- End diff --
    
    Keeping "various extra persisted location" files is definitely a bug.
    Such extra files are called "dangling references" in Apache Brooklyn and we 
have validation about it called minRequiredHealthy which checks a healthy 
quorum check. If the minRequiredHealthy validation doesn't have healthy objects 
quorum, Brooklyn fails to start.
    These failures are reported several times by clients.
    We may want to keep some of the extra locations for history and durability 
reasons, but then we have to modify the minRequiredHealthy validation 
accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to