Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1160#discussion_r50317896
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java
---
@@ -288,15 +288,33 @@ public synchronized boolean uncancel() {
}
@Override
- public synchronized boolean cancel(boolean mayInterruptIfRunning) {
+ public final synchronized boolean cancel(boolean
mayInterruptIfRunning) {
+ // semantics changed in 2016-01, previously "true" was
INTERRUPT_TASK_BUT_NOT_SUBMITTED_TASKS
+ return cancel(mayInterruptIfRunning ?
TaskCancellationMode.INTERRUPT_TASK_AND_DEPENDENT_SUBMITTED_TASKS
+ : TaskCancellationMode.DO_NOT_INTERRUPT);
+ }
+
+ public synchronized boolean cancel(TaskCancellationMode mode) {
--- End diff --
the super is marked `@Beta` -- have added `@Override @Beta`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
