Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1165#discussion_r50830660
--- Diff:
brooklyn-server/policy/src/test/java/org/apache/brooklyn/policy/ha/ConnectionFailureDetectorTest.java
---
@@ -37,19 +37,24 @@
import org.apache.brooklyn.core.entity.factory.ApplicationBuilder;
import org.apache.brooklyn.core.test.entity.LocalManagementContextForTests;
import org.apache.brooklyn.core.test.entity.TestApplication;
+import org.apache.brooklyn.policy.ha.HASensors.FailureDescriptor;
import org.apache.brooklyn.test.Asserts;
import org.apache.brooklyn.util.collections.MutableMap;
import org.apache.brooklyn.util.time.Duration;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
-import org.apache.brooklyn.policy.ha.HASensors.FailureDescriptor;
import com.google.common.base.Predicate;
import com.google.common.base.Predicates;
import com.google.common.collect.ImmutableMap;
import com.google.common.net.HostAndPort;
+@Test(groups="Integration")
+// can fail if a firewall is in place on high-numbered ephemeral ports;
--- End diff --
If this test fails because we can't open a serverSocket on a high-numbered
port, then I'm guessing quite a few more tests would also fail.
Happy to merge this. But longer term, might be worth artificially adding
such a firewall and seeing the full set of tests that fail as a result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
