Github user sjcorbett commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/112#issuecomment-208845961
  
    Thinking about this a bit more closely, you've deprecated a 
`ConfigKey<Function<Collection<Entity>, Entity>>` in favour of a 
`ConfigKey<RemovalStrategy>`, but the `RemovalStrategy` class implements 
`Function<Collection<Entity>, Optional<Entity>`. You could avoid all of the 
deprecation hassle by leaving the config key the same and altering 
`RemovalStrategy` to implement `Function<Collection<Entity>, Entity>`. The 
result is identical, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to