Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/181#discussion_r65897294
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2617,15 +2616,10 @@ public void run() {
}
// Get all the other port-forwarding mappings for this VM, and
release all of those
- Set<PortMapping> mappings;
- if (portForwardManager != null) {
- mappings = Sets.newLinkedHashSet();
-
mappings.addAll(portForwardManager.getLocationPublicIpIds(machine));
- if (nodeId != null) {
-
mappings.addAll(portForwardManager.getPortMappingWithPublicIpId(nodeId));
- }
- } else {
- mappings = ImmutableSet.of();
+ Set<PortMapping> mappings = Sets.newLinkedHashSet();
--- End diff --
```Java
Set<PortMapping> mappings =
MutableMap.copyOf(portForwardManager.getLocationPublicIpIds(machine));
if (nodeId != null) {
mappings.addAll(portForwardManager.getPortMappingWithPublicIpId(nodeId));
}
```
Yeah, it's pointless. Forget it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
