Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/29#discussion_r66147228
--- Diff: src/main/webapp/assets/tpl/apps/param.html ---
@@ -34,6 +34,10 @@
<input type="checkbox" class="param-value">
<% } %>
</td>
+ <% } else if (sensitive == true && type == 'java.lang.String') { %>
--- End diff --
Do we really need to check for type == String, or should we mask out
anything that seems to be sensitive?
As a silly example, there code be a 4-digit pin code (which someone has
represented as a number).
Presumably we can just mark it as password, get the value, and then rely on
our type coercions like we do everywhere else?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
