Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/180#discussion_r66537291
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTaskTags.java ---
@@ -190,9 +190,16 @@ protected WrappedStream(String streamType,
ByteArrayOutputStream stream) {
public Integer getStreamSize() {
return streamSize.get();
}
- // there is a stream api so don't return everything unless
explicitly requested!
+ // there is a stream call on Activity REST api which accesses
streamContent.get() directly;
+ // so when serializing the tag, abbreviate things
@JsonProperty("streamContents")
public String getStreamContentsAbbreviated() {
+ // TODO would be nice to just get the first 80 chars but
that's a refactoring
+ // which might affect persistence. if stream is very large
(100MB+) then we sometimes
--- End diff --
Agree we should be cautious about breaking persistence, so am happy to
merge as-is. But would be really nice if we refactor in a safe way (e.g.
keeping the old field, but changing the constructor args and adding a new
field), so we can write something that gets the truncated data. (And in the
future it could return it paginated, but not sure if that would be at all
sensible?!).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
