Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/196#discussion_r67017851
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/AbstractYamlTest.java
---
@@ -125,7 +125,7 @@ protected Entity createAndStartApplication(String...
multiLineYaml) throws Excep
}
protected Entity createAndStartApplication(Reader input) throws
Exception {
- return createAndStartApplication(Streams.readFully(input));
+ return createAndStartApplication(Streams.readFullyAndClose(input));
--- End diff --
Overall, I'm fine with this because it's just in tests. But it feels like
the responsibility of the caller to close the Reader that they created, rather
than this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
