Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/226
  
    @bostko we could include `SERVICE_STATE_EXPECTED` in the 
`assertServiceHealthy` - no strong feelings. It probably will never say actual 
is "running" if expected is not also something like running.
    
    Can you also add javadoc, then good to merge. For example:
    
        /**
          * Asserts sensors {@code service.isUp} is true, and that {@code 
service.state} is "running".
          * Setting these sensors is common behaviour for entities, but depends 
on the particular entity 
          * implementation.
          */
    
    And something similar for `assertServiceFailed`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to