Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/62#discussion_r76402034
--- Diff:
software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
@@ -222,17 +227,35 @@ public void update() {
Multimap<String, String> aRecordToCnames =
MultimapBuilder.hashKeys().hashSetValues().build();
Multimap<String, String> ipToAllNames =
MultimapBuilder.hashKeys().hashSetValues().build();
- for (Map.Entry<String, Entity> e : hostnameToEntity.entries())
{
- String domainName = e.getKey();
- Maybe<SshMachineLocation> location =
Machines.findUniqueMachineLocation(e.getValue().getLocations(),
SshMachineLocation.class);
- if (!location.isPresent()) {
- LOG.debug("Member {} of {} does not have an SSH
location so will not be configured", e.getValue(), this);
- continue;
- } else if (ipToARecord.inverse().containsKey(domainName)) {
+ for (Map.Entry<String, Entity> entry :
hostnameToEntity.entries()) {
+ String domainName = entry.getKey();
+ Entity entity = entry.getValue();
+
+ String address = null;
+
+ AttributeSensor<String> addressSensor =
getConfig(ADDRESS_SENSOR);
+ if (addressSensor!=null) {
+ address = entity.getAttribute(addressSensor);
+
--- End diff --
Remove blank line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
