Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/313#discussion_r76905392
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
 ---
    @@ -46,22 +46,26 @@
     
     /**
      * Pattern for resolving "decorations" on service specs / entity specs, 
such as policies, enrichers, etc.
    + *
      * @since 0.7.0
      */
    -@Beta
     public abstract class BrooklynEntityDecorationResolver<DT> {
     
         public final BrooklynYamlTypeInstantiator.Factory instantiator;
    -    
    +
         protected 
BrooklynEntityDecorationResolver(BrooklynYamlTypeInstantiator.Factory 
instantiator) {
             this.instantiator = instantiator;
         }
    -    
    +
    +    /** @deprected since 0.10.0 - use {@link #decorate(EntitySpec<?>, 
ConfigBag, Set<String>)} */
    +    @Deprecated
    +    public abstract void decorate(EntitySpec<?> entitySpec, ConfigBag 
attrs);
    --- End diff --
    
    make this `public final` not abstract with the implementation passing the 
empty `ImmutableSet` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to