Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/119#discussion_r77529695
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -197,6 +197,10 @@ public Builder credentials(String username, String
password) {
this.credentials = new UsernamePasswordCredentials(username,
password);
return this;
}
+ public Builder credentials(Credentials credentials) {
--- End diff --
Agree that we should avoid it if possible. Depending on the underlying
implementation being mutable and changing it **after** being passed (that's how
I understand the change) doesn't sound like a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
