Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/425#discussion_r87568111
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java
---
@@ -456,17 +457,16 @@ public boolean apply(final SecurityGroup input) {
*
*
* @param groupName The name of the security group to create
- * @param location The location in which the security group will be
created
* @param securityApi The API to use to create the security group
*
* @return the created security group
*/
- private SecurityGroup createBaseSecurityGroupInLocation(String
groupName, Location location, SecurityGroupExtension securityApi) {
- SecurityGroup group = addSecurityGroupInLocation(groupName,
location, securityApi);
+ private SecurityGroup createBaseSecurityGroupInLocation(String
groupName, JcloudsLocationSecurityGroupEditor groupEditor) {
+ SecurityGroup group =
groupEditor.createSecurityGroup(groupName).get();
String groupId = group.getProviderId();
int fromPort = 0;
- if (isOpenstackNova(location)) {
+ if (isOpenstackNova(groupEditor.getLocation())) {
groupId = group.getId();
--- End diff --
We should report these inconsistencies to jclouds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
