Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/448#discussion_r88812917
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsRateLimitedRetryLiveTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds;
+
+import java.util.List;
+import java.util.concurrent.Executors;
+
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.exceptions.Exceptions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import com.google.common.collect.Lists;
+import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+
+/**
+ * Tests provisioning machines, where it causes a lot of activity (in an
effort to be
+ * rate-limited!). We expect the retry to do suitable exponential backoff
that the retries
+ * eventually succeed, provisioning all the machines without error.
+ */
+public class JcloudsRateLimitedRetryLiveTest extends
AbstractJcloudsLiveTest {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(JcloudsRateLimitedRetryLiveTest.class);
+
+ public static final String LOCATION_SPEC = "jclouds:" +
AWS_EC2_PROVIDER + ":" + AWS_EC2_USEAST_REGION_NAME;
+
+ // Image: {id=us-east-1/ami-7d7bfc14, providerId=ami-7d7bfc14,
name=RightImage_CentOS_6.3_x64_v5.8.8.5, location={scope=REGION, id=us-east-1,
description=us-east-1, parent=aws-ec2, iso3166Codes=[US-VA]},
os={family=centos, arch=paravirtual, version=6.0,
description=rightscale-us-east/RightImage_CentOS_6.3_x64_v5.8.8.5.manifest.xml,
is64Bit=true},
description=rightscale-us-east/RightImage_CentOS_6.3_x64_v5.8.8.5.manifest.xml,
version=5.8.8.5, status=AVAILABLE[available], loginUser=root,
userMetadata={owner=411009282317, rootDeviceType=instance-store,
virtualizationType=paravirtual, hypervisor=xen}}
+ public static final String AWS_EC2_CENTOS_IMAGE_ID =
"us-east-1/ami-7d7bfc14";
+
+ protected ListeningExecutorService executor;
+
+ @BeforeMethod(alwaysRun=true)
+ @Override
+ public void setUp() throws Exception {
+ super.setUp();
+ executor =
MoreExecutors.listeningDecorator(Executors.newCachedThreadPool());
+ }
+
+ @AfterMethod(alwaysRun=true)
+ @Override
+ public void tearDown() throws Exception {
+ try {
+ super.tearDown();
+ } finally {
+ if (executor != null) executor.shutdownNow();
+ }
+ }
+
+ @Test(groups = {"Live", "Acceptance"})
+ public void testCreateOne() throws Exception {
+ doMany(1);
+ }
+
+ @Test(groups = {"Live", "Acceptance"})
--- End diff --
I marked this as "Acceptance" as well because I really don't think we
should be running tests to induce rate-limiting very often, and should not be
provisioning 20 VMs in a single test often either.
We should revisit our testng groups/profiles to make these more useful
longer term.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
