Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/449#discussion_r89103514
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/persist/FileBasedStoreObjectAccessorWriterTest.java
---
@@ -61,6 +76,30 @@ public void testFilePermissions600() throws Exception {
FileBasedObjectStoreTest.assertFilePermission600(file);
}
+ // Fails ~3 times on 5000 runs in Virtualbox (Ubuntu Xenial).
--- End diff --
I think it's worth cross-referencing the comment you added in
`RebindTestUtils.TIMEOUT`.
Other than that, LGTM and good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
