Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/473#discussion_r90475367
  
    --- Diff: 
utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java ---
    @@ -334,8 +335,14 @@ public void runRequiringTrue() {
                 try {
                     lastError = null;
                     done = exitCondition.call();
    +                hasLoggedTransientException = false;
                 } catch (Throwable e) {
    -                if (log.isDebugEnabled()) log.debug(description, e);
    +                if (hasLoggedTransientException) {
    +                    if (log.isDebugEnabled()) log.debug(description + " 
(repeated failure; excluding stacktrace): " + e);
    --- End diff --
    
    Do  not need to check `log.isDebugEnabled()` for simple logging like this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to