-1 (binding)

There are no NOTICE files in any of the 
"apache-brooklyn-0.10.0-rc2-client-cli-xxx" downloads.

---

I tested this RC by:
  * installing the rpm on CentOS 7
  * extracting the karaf distribution on OS X
  * using the above:
    * adding a location (both by YAML and the location wizard)
    * deploying all the examples from the application wizard
    * went through the UI for possible glitches
    * tried the linux and OS X br executables to connect to the instances

A common problem while testing is that I forgot to fix the entropy on the VMs 
**every** time.

I went through the check list:

[✓] Download links work.
[✓] Binaries work.
[✓] Checksums and PGP signatures are valid.
[✓] Expanded source archive matches contents of RC tag.
[✓] Expanded source archive builds and passes tests.
[✓] LICENSE is present and correct.
[-] NOTICE is present and correct, including copyright date.
[✓] All files have license headers where appropriate.
[✓] All dependencies have compatible licenses.
[✓] No compiled archives bundled in source archive.
[-] I follow this project’s commits list.

Used the following snippets to check some of the above:

List files without headers:
grep -rL "Licensed to the Apache Software Foundation" * | xargs grep -L 
"Copyright 201. The Apache Software Foundation." | less

Search for binary files:
find . | xargs -n1 file | awk -F $':' ' { t = $1; $1 = $2; $2 = t; print; } ' | 
sort | less

Verify the signatures:
for artifact in $(ls -1 | grep -v asc | grep -v md5 | grep -v sha1 | grep -v 
sha256 | grep -v downloads.txt); do
    md5sum -c ${artifact}.md5
    shasum -a1 -c ${artifact}.sha1
    shasum -a256 -c ${artifact}.sha256
    gpg2 --verify ${artifact}.asc ${artifact}
done

To compare the repo against the source archive:
diff -qr <repo> <expanded sources> | less

Confirmed licenses using:
mvn project-info-reports:dependencies


Svet.


> On 14.12.2016 г., at 15:51, Aled Sage <[email protected]> wrote:
> 
> +1 (binding)
> 
> I used the verify_brooklyn_rc.sh script to validate the checksums etc.
> 
> Confirmed that NOTICE is now included in apache-brooklyn-0.10.0-karaf.
> 
> Deployed apps to AWS, GCE and Softlayer, including a windows-based app to 
> AWS. All worked great!
> 
> Aled
> 
> 
> On 14/12/2016 12:30, Geoff Macartney wrote:
>> +1
>> 
>> [x] Download links work.
>> [x] Binaries work.
>> [x] Checksums and PGP signatures are valid.
>> [x] Expanded source archive matches contents of RC tag.
>> [x] Expanded source archive builds and passes tests.
>> [x] LICENSE is present and correct.
>> [x] NOTICE is present and correct, including copyright date.
>> [x] All files have license headers where appropriate.
>> [-] All dependencies have compatible licenses.
>> [x] No compiled archives bundled in source archive.
>> [x] I follow this project’s commits list.
>> 
>> Tested deploying sample apps on AWS with RPM on Centos7 and Karaf and
>> classic launcher on Ubuntu.
>> Tested with 'br' tool.
>> 
>> 
>> On Wed, 14 Dec 2016 at 10:28 Alex Heneveld <[email protected]>
>> wrote:
>> 
>> Agree this is not a blocker.  GETs work fine so people can see the API docs
>> and interact with most.  In fact I think this regression is tiny:  the
>> swagger page didn't support setting content-type and that's needed for most
>> of the POSTs, so they wouldn't work even with the CSRF token.
>> 
>> Best
>> Alex
>> 
>> 
>> On 14 December 2016 at 10:06, Svetoslav Neykov <
>> [email protected]> wrote:
>> 
>>> Good spot Mark. I see this as a minor problem which can be included as a
>>> "known issues" in the release notes.
>>> Happy to be convinced otherwise (for example by people voting with -1
>>> because of it).
>>> 
>>> Svet.
>>> 
>>> 
>>>> On 13.12.2016 г., at 22:32, Mark McKenna <[email protected]
>>> wrote:
>>>> Hi All,
>>>> 
>>>> Noticed one minor bug in the JSGUI while testing RC2.
>>>> In the swagger api doc view all non GET requests fail as swagger does
>> not
>>>> set the X-CSRF-TOKEN header
>>>> 
>>>> Unsure if this is a blocker for release ive raised a bug [1]
>>>> 
>>>> Cheers
>>>> Mark
>>>> 
>>>> [1] https://issues.apache.org/jira/browse/BROOKLYN-408
>>>> 
>>>> On 13 December 2016 at 11:40, Mark McKenna <mark.mckenna@cloudsoftcorp.
>>> com>
>>>> wrote:
>>>> 
>>>>> Hi All
>>>>> 
>>>>> TLDR +1
>>>>> 
>>>>> Ive re run the test for the below blueprints in a mixture of openstack
>> /
>>>>> aws & centos 6 / 7 with no issue
>>>>> 
>>>>> *Tested Blueprints*
>>>>>  * Cassandra [1] [2]
>>>>>  * CouchDB [3]
>>>>>  * Elasticsearch [4]
>>>>>  * Hyperledger [5]
>>>>>  * JBoss6 [6]
>>>>>  * JBoss7 [7]
>>>>>  * MariaDB [8]
>>>>>  * MongoDB [9]
>>>>>  * MySQL [10] [11]
>>>>>  * NodeJs [12]
>>>>>  * PostgreSQL [13]
>>>>>  * RabbitMQ [14]
>>>>>  * Redis [15]
>>>>>  * Riak [16] [17]
>>>>>  * Solr [18]
>>>>>  * Tomcat7 [19]
>>>>>  * Tomcat8 [20]
>>>>>  * Zookeeper [21] [22]
>>>>> 
>>>>> Cheers
>>>>> Mark
>>>>> 
>>>>> [1] https://github.com/brooklyncentral/brooklyn-apache-cassandra-node
>>>>> [2] https://github.com/brooklyncentral/brooklyn-
>>> apache-cassandra-database-
>>>>> fabric
>>>>> [3] https://github.com/brooklyncentral/brooklyn-couchdb-node
>>>>> [​4​]​ https://github.com/brooklyncentral/brooklyn-elastic-search-node​
>>>>> [​5​]​ ​https://github.com/cloudsoft/brooklyn-hyperledger
>>>>> [​6​]​ ​https://github.com/brooklyncentral/brooklyn-
>>>>> jboss-application-server-6
>>>>> [​7​]​ ​https://github.com/brooklyncentral/brooklyn-
>>>>> jboss-application-server-​7​
>>>>> [​8​]​ https://github.com/brooklyncentral/brooklyn-mariadb-node​
>>>>> [​9​] https://github.com/brooklyncentral/brooklyn-mongodb-server
>>>>> [​10​] https://github.com/brooklyncentral/brooklyn-mysql-node
>>>>> [​11​] https://github.com/brooklyncentral/brooklyn-
>>>>> mysql-master-slave-cluster
>>>>> [​12​] https://github.com/brooklyncentral/brooklyn-nodejs-application
>>>>> [​13​] https://github.com/brooklyncentral/brooklyn-postgresql-node
>>>>> [​14​] https://github.com/brooklyncentral/brooklyn-rabbitmq-broker
>>>>> [​15​] https://github.com/brooklyncentral/brooklyn-redis-server
>>>>> [​16​] https://github.com/brooklyncentral/brooklyn-riak-node
>>>>> [​17​] https://github.com/brooklyncentral/brooklyn-riak-cluster
>>>>> [​18​] https://github.com/brooklyncentral/brooklyn-apache-solr-node
>>>>> [​19​] https://github.com/brooklyncentral/brooklyn-tomcat-7-server
>>>>> [​20] https://github.com/brooklyncentral/brooklyn-tomcat-​8​-server
>>>>> [21] https://github.com/brooklyncentral/brooklyn-zookeeper-node
>>>>> [22]​ https://github.com/brooklyncentral/brooklyn-zookeeper-ensemble
>>>>> 
>>>>> 
>>>>> On 12 December 2016 at 06:37, Svetoslav Neykov <svetoslav.neykov@
>>>>> cloudsoftcorp.com> wrote:
>>>>> 
>>>>>> This is to call for a vote for the release of Apache Brooklyn 0.10.0.
>>>>>> 
>>>>>> This release comprises of a source code distribution, and a
>>> corresponding
>>>>>> binary distribution, and Maven artifacts.
>>>>>> 
>>>>>> The source and binary distributions, including signatures, digests,
>>> etc.
>>>>>> can
>>>>>> be found at:
>>>>>> 
>>>>>>  https://dist.apache.org/repos/dist/dev/brooklyn/apache-brook
>>>>>> lyn-0.10.0-rc2
>>>>>> 
>>>>>> The artifact SHA-256 checksums are as follows:
>>>>>> 
>>>>>>  7afbf2c4a6159bba490dd806a4f0df7c90b364f25334fd102dfd09d42463db0f
>>>>>> *apache-brooklyn-0.10.0-rc2-bin.tar.gz
>>>>>>  8d0860796d93046b936594bab109f8804ced82bce9da66d3afb91f2b19d5a9f9
>>>>>> *apache-brooklyn-0.10.0-rc2-bin.zip
>>>>>>  bfade7b76d10cfde87ec69c574ab14e9b2f2055689f122bb00b17bf1f223d93f
>>>>>> *apache-brooklyn-0.10.0-rc2-karaf.tar.gz
>>>>>>  0986b0c8f5d696d62a997887bdd08630c8dcd19d094a5da5edc36c66f3764c20
>>>>>> *apache-brooklyn-0.10.0-rc2-karaf.zip
>>>>>>  80ed6b1bbaa2768057364881e30eec5071a715a5303e74c0eb0db08ab579121f
>>>>>> *apache-brooklyn-0.10.0-1.noarch.rpm
>>>>>>  66bfae3cdb47f672b93993b75a1cddb85d19d5ad48311f81e86f80c23faaee09
>>>>>> *apache-brooklyn-0.10.0-rc2-src.tar.gz
>>>>>>  08d4e76b66c5cf16fbca0e7a4ccedcc3ff6004ea33f38a6b37f3474262283086
>>>>>> *apache-brooklyn-0.10.0-rc2-src.zip
>>>>>>  95ce1b434f94ac057d599312f113550bf05c857c3af551c13e2c02752827cb75
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-linux.tar.gz
>>>>>>  e3b8a5335dc4ca8a66e50ab1f8b7660d3982863011dfc2e80dd32ebd1c79e345
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-linux.zip
>>>>>>  0c592b16c7e783df71a7ce0b61bcc8d868340b40694c4dd79259ab2392c2aeb4
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-macosx.tar.gz
>>>>>>  f43d493dc3cf29f2e98d8881bb21e5dbe5f022f0c7b1eeb9ffd3b7f40cf471f4
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-macosx.zip
>>>>>>  70024484c7edca1d9c4f5ccb6dd14764c3fb2fcd5f59f4a6967073ede7c222a9
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-windows.tar.gz
>>>>>>  dec02166fa2cf9392c139d96b2dfbaa8ed2e10a5485e1221dd421b2a18daaa89
>>>>>> *apache-brooklyn-0.10.0-rc2-client-cli-windows.zip
>>>>>>  8e82d8b484be91ea9900f5b6b5047e0d29a2d0c1edde5a7114da44418b8a7f58
>>>>>> *apache-brooklyn-0.10.0-rc2-vagrant.tar.gz
>>>>>>  00dfbba22becbed5126b52fbd9a288b1d9d4c47fdc54b305a696a9f7d241d6ba
>>>>>> *apache-brooklyn-0.10.0-rc2-vagrant.zip
>>>>>> 
>>>>>> The Nexus staging repository for the Maven artifacts is located at:
>>>>>> 
>>>>>>    https://repository.apache.org/content/repositories/orgapache
>>>>>> brooklyn-1032
>>>>>> 
>>>>>> All release artifacts are signed with the following key:
>>>>>> 
>>>>>>    https://people.apache.org/keys/committer/svet.asc
>>>>>> 
>>>>>> KEYS file available here:
>>>>>> 
>>>>>>    https://dist.apache.org/repos/dist/release/brooklyn/KEYS
>>>>>> 
>>>>>> 
>>>>>> The artifacts were built from git commit IDs:
>>>>>> 
>>>>>> brooklyn: 3ece5a3c5c03bdecb66a133da8bdafdb798fe150
>>>>>> brooklyn-client: 0594d27aa68ac1c86e2b4672a447336042d92496
>>>>>> brooklyn-dist: 14ccdf662e24f97a985909367c8e2e4ffe75c985
>>>>>> brooklyn-docs: d75752725ef6683a0f52e3059ed475dc69872f9e
>>>>>> brooklyn-library: 9fbc78cb4a9d1dccdbdbb70a1ee48f2afddfe067
>>>>>> brooklyn-server: ad34129fd19b4b4c6d65a6e906c6f04e4185ef31
>>>>>> brooklyn-ui: a6e2e8bccfdd98b4f7155b5be86f5b85149e0f33
>>>>>> All of the above have been tagged as "apache-brooklyn-0.10.0-rc2"
>>>>>> 
>>>>>> Please vote on releasing this package as Apache Brooklyn 0.10.0.
>>>>>> 
>>>>>> The vote will be open for at least 72 hours.
>>>>>> [ ] +1 Release this package as Apache Brooklyn 0.10.0
>>>>>> [ ] +0 no opinion
>>>>>> [ ] -1 Do not release this package because ...
>>>>>> 
>>>>>> 
>>>>>> Thanks!
>>>>>> Svet.
>>>>>> 
>>>>>> 
>>>>>> CHECKLIST for reference
>>>>>> 
>>>>>> [ ] Download links work.
>>>>>> [ ] Binaries work.
>>>>>> [ ] Checksums and PGP signatures are valid.
>>>>>> [ ] Expanded source archive matches contents of RC tag.
>>>>>> [ ] Expanded source archive builds and passes tests.
>>>>>> [ ] LICENSE is present and correct.
>>>>>> [ ] NOTICE is present and correct, including copyright date.
>>>>>> [ ] All files have license headers where appropriate.
>>>>>> [ ] All dependencies have compatible licenses.
>>>>>> [ ] No compiled archives bundled in source archive.
>>>>>> [ ] I follow this project’s commits list.
>>>>>> 
>>>>>> 
>>>>> 
>>>>> --
>>>>> 
>>>>> *Mark McKenna*
>>>>> 
>>>>>  *twitter:* @m4rkmckenna <https://twitter.com/m4rkmckenna>
>>>>> 
>>>>> *  pgp:* A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7
>>>>> <https://pgp.mit.edu/pks/lookup?op=get&search=0x2B5DC759B1EB76A7>
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> *Mark McKenna*
>>>> 
>>>>  *twitter:* @m4rkmckenna <https://twitter.com/m4rkmckenna>
>>>> 
>>>> *  pgp:* A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7
>>>> <https://pgp.mit.edu/pks/lookup?op=get&search=0x2B5DC759B1EB76A7>
>>> 
> 

Reply via email to