Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/513#discussion_r95553319
--- Diff:
utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
@@ -75,6 +76,20 @@
}
}
+ /**
+ * Alternative implementation of {@link
ScriptBytecodeAdapter#isCase(Object, Object)}<br>
+ * Stripped down to work only for caseExpression of type
<code>java.lang.Class</code>.<br>
+ * It behaves the same way only for cases when caseExpression
<code>java.lang.Class</code> does <b>not</b> implement <code>isCase</code>
method.<br>
+ * It goes directly to {@link DefaultGroovyMethods#isCase(Object,
Object)} method instead of using Groovy dynamic invocation.<br>
+ * This safes extra operations and locks used in Groovy dynamic
invocation. See <a
href="https://issues.apache.org/jira/browse/BROOKLYN-424";>BROOKLYN-424</a>.
--- End diff --
Typo "safes". Maybe something like "This saves extra operations and
avoids the locks used ...."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
