Github user drigodwin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/92#discussion_r101538525
  
    --- Diff: 
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java
 ---
    @@ -198,24 +211,36 @@ public void customize() {
         @Override
         public void launch() {
             log.info("Launching  {}", entity);
    -        newScript(MutableMap.of(USE_PID_FILE, false), LAUNCHING)
    -                .body.append(String.format("nohup ./bin/couchdb -p %s -a 
%s -o couchdb-console.log -e couchdb-error.log -b &", getPidFile(), 
Os.mergePathsUnix(getRunDir(), getCouchDBConfigFileName())))
    -                .execute();
    +        String couchDBPath = isV2()? 
getExpandedInstallDir()+"/rel/couchdb/bin/couchdb" : "./bin/couchdb";
    +        ScriptHelper script = newScript(MutableMap.of(USE_PID_FILE, 
false), LAUNCHING);
    --- End diff --
    
    `USE_PID_FILE` would write it to a `pid.txt` whereas this expects a 
`couchdb.pid`. I could swap it but I think it might break the 1.x version.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to