Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/693#discussion_r117982151
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/javalang/coerce/TypeCoercerExtensible.java
---
@@ -165,13 +165,6 @@ public static TypeCoercerExtensible newEmpty() {
}
}
- //for enums call valueOf with the string representation of the
value
- if (targetType.isEnum()) {
- result =
EnumTypeCoercions.tryCoerceUntyped(Strings.toString(value),
(Class<T>)targetType);
- if (result!=null && result.isPresent()) return result;
- if (result!=null && firstError==null) firstError = result;
- }
-
//now look in registry
synchronized (registry) {
--- End diff --
Interesting! Conceptually it could, but I think I'll leave as-is because
the code using this wants to call `TypeCoercerExtensible.registerAdapter()` so
it needs to know about the `registry`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
