GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/737
[WIP] Clean up inference around parsing `name:version` strings
We've had some rough heuristics how to find name and version but not a
strict definition.
This adds strict definitions in `RegisteredTypeNaming` (first commit).
It then changes core to prefer these methods. It doesn't change behaviour
(except in a few fringe cases noted), but it does add log warnings where we
were relying on hokey old strategies (previously assumed something was a
version if it started with a number, that's it).
Then clean up a bunch of deprecated stuff where the above was used.
The methods in `RegisteredTypeNaming` let us hedge a little bit whether we
want to be strict with OSGi versions or not. That's a subject for another PR
(but an important one as discussed at #672).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server version-id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/737.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #737
----
commit 36ffdeeca0ac5290727b3bf5d2a7267664e9638a
Author: Alex Heneveld <[email protected]>
Date: 2017-06-16T08:49:44Z
remove REST reference to removed method
commit 3860c3498d63a9a9d880480363c7947599d40a7c
Author: Alex Heneveld <[email protected]>
Date: 2017-06-16T10:53:33Z
new utilities for registered type (catalog item id) naming syntax
commit 607fc853aa395915e15d527405b7a7a8a6e97b48
Author: Alex Heneveld <[email protected]>
Date: 2017-06-16T12:24:28Z
move many things to use RegisteredTypeNaming rather than hokey
`looksLikeVersionedId`
commit eb08f8ec0d65b59bb2c4201a98632aa070ddac97
Author: Alex Heneveld <[email protected]>
Date: 2017-06-16T12:38:45Z
notes on related methods for looking up catalog items flexibly
commit c9d03c93e35eb5417ca6168207f4b0ddc3de9e7c
Author: Alex Heneveld <[email protected]>
Date: 2017-06-16T12:46:20Z
remove deprecated CAMP ServiceTypeResolver
changed a while ago to EntitySpecResolver; removes references to catalog
items and hokey lookup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
