GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/742
DefaultAzureArmNetworkCreator improvements
* Donât use RETURNS_DEEP_STUBS as causes non-deterministic test failure
on my dev machine (ClassCastException when calling `thenReturn(...)`!)
* Tidy logging
* Assert create() calls are made
* Minor renames (e.g. _PREFIX to indicate DEFAULT_RESOURCE_GROUP constant
is just the naming prefix)
Note the aim of the logging improvements is to ensure there is just one
log.info message per provision request to say we're messing with the user's
templateOptions, and one info message if we're creating default resource group,
and one info message if creating default network/subnet. If we don't touch the
user's config then we just log at debug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server pr739-minor-tidy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #742
----
commit d198e28bef812ab542295d0dd217aa6a7344d6e3
Author: Aled Sage <[email protected]>
Date: 2017-06-22T10:55:46Z
DefaultAzureArmNetworkCreator improvements
* Donât use RETURNS_DEEP_STUBS as causes non-deterministic test failure
on my dev machine (ClassCastException when calling `thenReturn(...)`!)
* Tidy logging
* Assert create() calls are made
* Minor renames (e.g. _PREFIX to indicate DEFAULT_RESOURCE_GROUP
constant is just the naming prefix)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
