Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/734#discussion_r123992282
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -518,6 +574,46 @@ protected Object getStringKey(String key, boolean
markUsed) {
/**
* @return Unresolved configuration value. May be overridden to
provide resolution - @see {@link ResolvingConfigBag#getStringKeyMaybe(String,
boolean)}
*/
+ protected synchronized Maybe<Object> getKeyMaybe(ConfigKey<?> key,
boolean markUsed) {
--- End diff --
There's a fair bit of duplication of code here with the method above, it
would be nice to reduce that somehow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
