+1 (non-binding) Checks successfully completed: [✓] Download links work. [✓] Checksums and PGP signatures are valid. [✓] Expanded source archive matches contents of RC tag. [✓] Expanded source archive builds and passes tests. [✓] LICENSE is present and correct. [✓] NOTICE is present and correct, including copyright date. [✓] No compiled archives bundled in source archive. [✓] All files have license headers where appropriate. => I trust the RAT maven plugin for this, which passed successfully during the source build
For the following item, I'm not aware of any new dependencies added so LGTM: [ ] All dependencies have compatible licenses. I started the default bin distribution (karaf) and deployed successfully 3 " Resilient Load-Balanced Bash Web Cluster" on AWS, Azure and GCE. I stopped Brooklyn then restarted it to check the rebind, which was successful. ---- Note that I used my updated version of the verify script[1] and all went fine, even the sources build. [1] On Fri, 22 Sep 2017 at 14:16 Duncan Grant <duncan.gr...@cloudsoft.io> wrote: > +1 (non-binding) > > [✓] Download links work. > [✓] Binaries work. > [✓] Checksums and PGP signatures are valid. > [✓] Expanded source archive matches contents of RC tag. > [ ] Expanded source archive builds and passes tests. > [✓] LICENSE is present and correct. > [✓] NOTICE is present and correct, including copyright date. (Although > date should really be 2017!) > [LGTM] All files have license headers where appropriate. > [LGTM] All dependencies have compatible licenses. > [✓] No compiled archives bundled in source archive. > [✓] I follow this project’s commits list. > > > On Fri, 22 Sep 2017 at 10:33 Duncan Godwin <dgod...@redwintechnologies.com > > > wrote: > > > This is to call for a vote for the release of Apache Brooklyn 0.12.0. > > > > This release comprises of a source code distribution, and a corresponding > > binary distribution, and Maven artifacts. > > > > The source and binary distributions, including signatures, digests, etc. > > can > > be found at: > > > > > > > https://dist.apache.org/repos/dist/dev/brooklyn/apache-brooklyn-0.12.0-rc3 > > > > The artifact SHA-256 checksums are as follows: > > > > f748ff53ea665a0cabcf42df4ecb346d0f688574286e8a251b37dec282b63a47 > > *apache-brooklyn-0.12.0-rc3-1.noarch.rpm > > 54c85747d3622cac5842adcc738f93da9d160cd8a11f8903583c86363c8a6c4e > > *apache-brooklyn-0.12.0-rc3-bin.tar.gz > > f63f6a950d8ea40694988fde3575653653c63808bf9311cbc6bf8c074e28f2b1 > > *apache-brooklyn-0.12.0-rc3-bin.zip > > de8c2098594edd7e2b60a4a6a44d8b957a7c1b9e7498015e27571e7835054e16 > > *apache-brooklyn-0.12.0-rc3-classic.tar.gz > > 5a913a085e0425f38c50e6a117d0aed7f0624f0f528fc63b5d68266c6036046d > > *apache-brooklyn-0.12.0-rc3-classic.zip > > 2e3f2acba804b81efa74f71fa48e90965503e8eaf50aecc2b0d14a6f4a08f31a > > *apache-brooklyn-0.12.0-rc3-client-cli-linux.tar.gz > > 9fef1a73117f568ffeb41da6e4d4cb8ed895b36305df079289f31b3b874d5e4c > > *apache-brooklyn-0.12.0-rc3-client-cli-linux.zip > > 54004fcec86ff22cea23d460c7e25c243d3a1f67227931adb0067a8611bc1ee3 > > *apache-brooklyn-0.12.0-rc3-client-cli-macosx.tar.gz > > b2e26523bee04420dadac73989a3265360b30f4041c68ed364c4aaf10e0addee > > *apache-brooklyn-0.12.0-rc3-client-cli-macosx.zip > > 86a7848f1f1eb81eaa20116df2caa2d80409515a1268b085f6fde828b18b08ac > > *apache-brooklyn-0.12.0-rc3-client-cli-windows.tar.gz > > 36f14ecbced097561ef9621a28beba6343d96402424974a302560bb429b2685f > > *apache-brooklyn-0.12.0-rc3-client-cli-windows.zip > > ed0e89f635501adc8cc347d22a412f29b03b3a4f9967911381e21fd3bc2333e9 > > *apache-brooklyn-0.12.0-rc3-src.tar.gz > > 0764a014905ead1901d9a7074e90b5acde21c98137af25c4ef543f750bc05cf1 > > *apache-brooklyn-0.12.0-rc3-src.zip > > 5fb368d12fb0f2a0a58f112b8bd39465c39827056b3de7d0dc86a40043f30c48 > > *apache-brooklyn-0.12.0-rc3-vagrant.tar.gz > > 518e6eb47a0faaa99f1c2eb74167bfeb107ad8f332adf80fa7bc897990684a8b > > *apache-brooklyn-0.12.0-rc3-vagrant.zip > > > > The Nexus staging repository for the Maven artifacts is located at: > > > > > > > https://repository.apache.org/content/repositories/orgapachebrooklyn-1051 > > > > All release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/drigodwin.asc > > > > KEYS file available here: > > > > https://dist.apache.org/repos/dist/release/brooklyn/KEYS > > > > The artifacts were built from git commit IDs: > > > > brooklyn: 473deebda6e214fd1f13187563aeea5219fceef8 > > brooklyn-client: fbbbb31e24a9daa5be3464b62e171603a6c6eae3 > > brooklyn-dist: 416ebc77473452e26f95a41c771feabf138979db > > brooklyn-docs: 6184fe07eaf9d69198934c92ad198a7d76dcbfdd > > brooklyn-library: 73b199771e5baa6681afe89d6cc0cdcaad620afb > > brooklyn-server: 4268b016191f3a5f049a2c9baa0e1befb8defc22 > > brooklyn-ui: bc5be4430fd83ebc6819113f1393f1231475ff76 > > > > All of the above have been tagged as "apache-brooklyn-0.12.0-rc3" > > > > Please vote on releasing this package as Apache Brooklyn 0.12.0. > > > > The vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Brooklyn 0.12.0 > > [ ] +0 no opinion > > [ ] -1 Do not release this package because ... > > > > > > Thanks! > > > > Duncan > > > > > > CHECKLIST for reference > > > > [ ] Download links work. > > [ ] Binaries work. > > [ ] Checksums and PGP signatures are valid. > > [ ] Expanded source archive matches contents of RC tag. > > [ ] Expanded source archive builds and passes tests. > > [ ] LICENSE is present and correct. > > [ ] NOTICE is present and correct, including copyright date. > > [ ] All files have license headers where appropriate. > > [ ] All dependencies have compatible licenses. > > [ ] No compiled archives bundled in source archive. > > [ ] I follow this project’s commits list. > > > -- Thomas Bouron • Senior Software Engineer @ Cloudsoft Corporation • https://cloudsoft.io/ Github: https://github.com/tbouron Twitter: https://twitter.com/eltibouron
