Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/867#discussion_r147382359
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/typereg/BasicManagedBundle.java ---
    @@ -135,6 +145,9 @@ public boolean equals(Object obj) {
                 // this makes equality with other OsgiBundleWithUrl items 
symmetric,
                 // but for two MB's we look additionally at checksum
                 if (!Objects.equal(checksum, 
((ManagedBundle)other).getChecksum())) return false;
    +            
    +            // only equal if have the same ManagedBundle uid; important 
for persistence.changeListener().unmanage()
    +            if (!Objects.equal(getId(), ((ManagedBundle)other).getId())) 
return false;
    --- End diff --
    
    agree, should have explicit methods to check or compare the 
`VersionedName`s where that is the item of interest


---

Reply via email to