Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/918#discussion_r158264960
  
    --- Diff: 
utils/common/src/main/java/org/apache/brooklyn/util/http/executor/UsernamePassword.java
 ---
    @@ -16,28 +16,14 @@
      * specific language governing permissions and limitations
      * under the License.
      */
    -package org.apache.brooklyn.util.http.executor;
    -
    -import com.google.common.annotations.Beta;
     
    -@Beta
    -public class UsernamePassword implements Credentials {
    -    private final String username;
    -    private final String password;
    +package org.apache.brooklyn.util.http.executor;
     
    +/**
    + * @deprecated since 1.0.0 use {@link 
org.apache.brooklyn.util.http.auth.UsernamePassword} instead.
    + */
    +public class UsernamePassword extends 
org.apache.brooklyn.util.http.auth.UsernamePassword {
    --- End diff --
    
    Should this also implement 
`org.apache.brooklyn.util.http.executor.Credentials`, for backwards 
compatibility?


---

Reply via email to