[
https://issues.apache.org/jira/browse/BROOKLYN-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605676#comment-16605676
]
ASF GitHub Bot commented on BROOKLYN-600:
-----------------------------------------
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/986
BROOKLYN-600: cleanup entities on deploy-failure
Fix for https://issues.apache.org/jira/browse/BROOKLYN-600
Note the `LocalEntityManager. discardPremanaged(Entity)` is a bit more
complex/long that it might need to be because I want to make sure it does no
harm - fail if the entity or any child is already managed (because then should
call `unmanage()` instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-600
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #986
----
commit a87e6692a54a10d389165fd82c93b3fd2f4ccc03
Author: Aled Sage <aled.sage@...>
Date: 2018-09-06T11:38:05Z
BROOKLYN-600: cleanup entities on deploy-failure
----
> Failed blueprint deployment: entities not cleaned up under-the-covers
> ---------------------------------------------------------------------
>
> Key: BROOKLYN-600
> URL: https://issues.apache.org/jira/browse/BROOKLYN-600
> Project: Brooklyn
> Issue Type: Bug
> Affects Versions: 0.12.0
> Reporter: Aled Sage
> Priority: Major
>
> When a blueprint deployment fails, it can leave partially-created entities
> behind. These are referenced under-the-covers in
> {{LocalEntityManager.preRegisteredEntitiesById}} and
> {{preManagedEntitiesById}}, so are entirely hidden from the user. However, it
> is bad that we leave them around, and it was a contributing factor to
> https://issues.apache.org/jira/browse/BROOKLYN-599.
> For example, deploying this blueprint fails (because {{QpidQueue}} entity
> expects to have as a parent a {{QpidBroker}}).
> ```
> services:
> - type: org.apache.brooklyn.entity.messaging.qpid.QpidQueue
> ```
> However, the failed app/entity is still held in memory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
