GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/83

    Fix the remove button within overflow menu for adjuncts

    Previously, the `Remove` item present within the overflow menu (top right) 
of the `spec-editor` wasn't removing an adjunct. There was 2 issues causing 
this behaviour:
    1. The `Remove` item wasn't checking the entity family, hence didn't delete 
any adjunct (as methods are different than removing a child)
    2. The `refreshTypeMetadata` was setting the wrong entity family for 
adjuncts

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui 
fix/remove-adjunt-from-menu

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #83
    
----
commit 9558a9a0b9cc1ebc91a7324d443f3d2526539193
Author: Thomas Bouron <thomas.bouron@...>
Date:   2018-10-10T14:34:10Z

    Fix issue with adjunct deletion from overflow menu

commit 639298b38328e4861ee53acedd0a929e82f62eae
Author: Thomas Bouron <thomas.bouron@...>
Date:   2018-10-11T13:27:56Z

    Fix issue that was setting the wrong type for adjunct on refresh

----


---

Reply via email to