Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/109#discussion_r234928083
  
    --- Diff: 
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
 ---
    @@ -42,14 +42,15 @@ const TYPES = [
     ];
     
     angular.module(MODULE_NAME, [angularAnimate, uibModal, brUtils])
    -    .directive('catalogSaver', ['$rootScope', '$uibModal', '$injector', 
'composerOverrides', 'blueprintService', saveToCatalogModalDirective])
    +    .directive('catalogSaver', ['$rootScope', '$uibModal', '$injector', 
'$filter', 'composerOverrides', 'blueprintService', 
saveToCatalogModalDirective])
         .directive('catalogVersion', ['$parse', catalogVersionDirective])
    +    .directive('blueprintNameOrSymbolicNameAndBundleIdRequired', 
blueprintNameOrSymbolicNameAndBundleIdRequiredDirective)
    --- End diff --
    
    Wow, that a very loooooong name. Could we come up with something shorter 
like `blueprintNameValidator`? The name doesn't need to say what it does exactly


---

Reply via email to